Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: update rust toolchains #1945

Closed
wants to merge 2 commits into from
Closed

CI: update rust toolchains #1945

wants to merge 2 commits into from

Conversation

dannywillems
Copy link
Member

@dannywillems dannywillems marked this pull request as draft March 8, 2024 14:59
@dannywillems dannywillems force-pushed the dw/update-ci-rust-version branch 2 times, most recently from e798afd to 5acc2a2 Compare March 8, 2024 15:18
@dannywillems dannywillems marked this pull request as ready for review March 8, 2024 15:18
@dannywillems dannywillems mentioned this pull request Mar 8, 2024
Closed
@dannywillems dannywillems self-assigned this Mar 8, 2024
@dannywillems dannywillems force-pushed the dw/update-ci-rust-version branch from 5acc2a2 to 32dd8b1 Compare March 8, 2024 15:20
volhovm
volhovm approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@volhovm volhovm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New clippy -- new life! 🎉

.github/workflows/rust.yml
@@ -15,7 +15,7 @@ jobs:
run_checks:
strategy:
matrix:
rust_toolchain_version: ["1.71", "1.72", "1.73", "1.74"]
rust_toolchain_version: ["1.71", "1.72", "1.73", "1.74", "1.75", "1.76", "beta"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure about beta though?..

Copy link
Member

@volhovm volhovm Mar 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plus do we have to support 1.71 still? CI might not like building 75% more versions than it does now.

@dannywillems
Copy link
Member Author

Oh no, the doc does not build...

error: internal compiler error: compiler/rustc_middle/src/ty/generic_args.rs:184:43: expected a const, but found another kind

@dannywillems
Copy link
Member Author

Gonna close it as old.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@volhovm volhovm volhovm approved these changes

@querolita querolita Awaiting requested review from querolita

Assignees

@dannywillems dannywillems

Labels
CI improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dannywillems @volhovm